Skip to content

stream: implement finished() for ReadableStream and WritableStream#46205

Merged
nodejs-github-bot merged 16 commits intonodejs:mainfrom
debadree25:ft/finished-webstreams
Jan 18, 2023
Merged

stream: implement finished() for ReadableStream and WritableStream#46205
nodejs-github-bot merged 16 commits intonodejs:mainfrom
debadree25:ft/finished-webstreams

Conversation

@debadree25
Copy link
Member

@debadree25 debadree25 commented Jan 13, 2023 •
edited
Loading

Implemented finished() for ReadableStreams and WritableStreams and added tests.

Refs: #39316

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

@jasnell jasnell jasnell approved these changes

@ronag ronag ronag approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

+1 more reviewer

@kanongil kanongil kanongil left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. semver-minor PRs that contain new features and should be released in the next minor version. web streams

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@debadree25 @nodejs-github-bot @mcollina @jasnell @kanongil @ronag @RaisinTen @aduh95